#feat: Add demo for JEP 357 - Migrate from Mercurial to Git #315
Conversation
| java16DemoPool.add(new VectorAPIDemo()); | ||
| // JEP 347 | ||
| java16DemoPool.add(new Cpp14FeaturesDemo()); | ||
| // Inside the list/map initialization in the JDK 16 helper file |
There was a problem hiding this comment.
Here only // JEP 375 comment should be placed, as for other demos
| java16DemoPool.add(new Cpp14FeaturesDemo()); | ||
| // Inside the list/map initialization in the JDK 16 helper file | ||
| // ... other demos ... | ||
| demos.add(new org.javademos.java16.jep357.MercurialToGitMigration()); // JEP 357 |
There was a problem hiding this comment.
For consistency with other demos, do not use absolute import path here. Use import at the begining of the file and here only class name.
| import org.javademos.commons.IDemo; | ||
|
|
||
| /** | ||
| * ## JEP 357: Migrate from Mercurial to Git |
There was a problem hiding this comment.
Please, change to Markdown format as in other demos. Check IDemo.java for reference.
| public void demo() { | ||
| info(357); | ||
|
|
||
| System.out.println("This JEP was an infrastructure project to migrate the OpenJDK Community's source code repositories."); |
There was a problem hiding this comment.
The information are correct, but please, do not use println statements for explaining. The output would be too long if all demos be like that. Turn them to comments.
AloisSeckar
added
the
changes requested
|
Since #313 was merged into main, which changes the way of loading the demo files, merge conflicts inevitably appeared in this PR and will have to be resolved. Please, sync your checkouts with current state of |
|
@Akshay4754 will you be able to address the feedback and solve the merge conflicts? I tried to do it, but GitHub web editor cannot handle it, must be done locally in your checkout. Or you can create a new fork and re-create changes related to JEP 357. |
2 participants
closes #252